Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #4259 #4277

Merged
merged 13 commits into from
Jun 10, 2024
Merged

fixed #4259 #4277

merged 13 commits into from
Jun 10, 2024

Conversation

dnyandeepchute
Copy link
Contributor

PR Description 📜

text was not visible in light mode
Fixes #4259


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

before:
Screenshot 2024-06-06 124131
Screenshot 2024-06-06 124140

after:
Screenshot 2024-06-06 124103
Screenshot 2024-06-06 124117



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 6, 2024

Thank you @dnyandeepchute ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dnyandeepchute,
You need to make the following changes:

  • Please create a new folder inside the "Games" folder.
  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@dnyandeepchute
Copy link
Contributor Author

@kunjgit it was a bug, please review it.

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dnyandeepchute,
You need to make the following changes:

  • Please create a new folder inside the "Games" folder.
  • Please add a README.md file inside the newly created folder.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dnyandeepchute,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.

Hoping that you will make those changes soon 🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dnyandeepchute,
You need to make the following changes:

  • Please create a new folder inside the "Games" folder.
  • Please add a README.md file inside the newly created folder.

Hoping that you will make those changes soon 🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dnyandeepchute,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.

Hoping that you will make those changes soon 🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dnyandeepchute,
You need to make the following changes:

  • Please create a new folder inside the "Games" folder.
  • Please add a README.md file inside the newly created folder.

Hoping that you will make those changes soon 🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dnyandeepchute,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.

Hoping that you will make those changes soon 🚀

@dnyandeepchute dnyandeepchute requested a review from kunjgit June 7, 2024 05:50
@dnyandeepchute
Copy link
Contributor Author

@kunjgit please merge this, thank you.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You dont need extra files for bug correction remove those files !!
Hoping you will make changes soon!!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this file if not needed!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done please check.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this file if not needed!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done please check.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not nedded !! Remove this one..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done please check.

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dnyandeepchute,
You need to make the following changes:

  • Please create a new folder inside the "Games" folder.
  • Please add a README.md file inside the newly created folder.

Hoping that you will make those changes soon 🚀

@dnyandeepchute
Copy link
Contributor Author

dnyandeepchute commented Jun 9, 2024

@ishita-43 done please check.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added the level1 Documentation and small bug fixes in gssoc label Jun 9, 2024
@ishita-43 ishita-43 added Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 9, 2024
@dnyandeepchute
Copy link
Contributor Author

dnyandeepchute commented Jun 9, 2024

@ishita-43 it was for level3, is it??

@ishita-43
Copy link
Collaborator

@ishita-43 it was for level3, is it??

YOU DID bug removal right!!
If its the case we place bugs removal in level1

@kunjgit kunjgit merged commit 35854f8 into kunjgit:main Jun 10, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 10, 2024

Thank you @dnyandeepchute , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested ⚒️ Changes have to be done gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc Pending ⏱️ Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: text not visible
3 participants